"Edited" flag not cleared when opening a file from disk

Two things, likely related:

  1. the Open From Disk menu option does not warn you if you have unsaved work
  2. the regular Open menu option sometimes incorrectly warns you about unsaved work:
    1. Open Hookpad
    2. Make any change
    3. Open a local file. Do not modify it!
    4. Attempt to open a cloud file
    5. “You have unsaved changes…”

Side feature request: could you add keyboard shortcuts for Open From Disk and Save To Disk?

Thing 1 appears to be fixed in 2.33.4. Thanks!

Thing 2 is still broken, but now applies to both Open and Open From Disk. The root cause is likely that the Edited flag isn’t cleared when opening a file from disk.

Still hoping to get keyboard shortcuts for Open From Disk and Save To Disk. I work almost entirely from disk since the disk file system has folders.

Thanks for bringing this up again. I fixed the edited flag/ unsaved changes warning bug. Now it gets reseted after loading a song from disk. This will work after the next update.

What’s already working are the requested keyboard short cuts. You can use Cmd + Shift+ O, or Ctrl + Shift + O, or Alt + Shift + O for opening a song from disk. Saving to disk works the same way. Cmd or Ctrl or Alt + Shift + S.

1 Like

Just noticed another thing: Saving to disk doesn’t clear the edited flag. I’ll save to disk, then try to open a file, and get warned I have unsaved work, which makes me second guess myself.

It is difficult or impossible though to determine whether a user actually saves a file or just cancels the system dialog, so maybe this current behavior is best - just assume it still isn’t saved. Hookpad could maybe warn about potentially unsaved work.

Thank you for reporting this!

I thought a bit about this. You’re right, there is no way for Hookpad to figure out if the song was actually saved or if the download was cancelled. So I created a setting where can turn off the unsaved changes warning after saving to disk.

Screenshot 2025-02-20 at 09.38.19

I think this is the best we can do in this scenario. It should work after the next update.

Regards!
Dennis

1 Like